MTSR/mail
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary condition

Browse Source 
On (un)select all, both unselect and select start with the same block, then it is better to remove conditions that reduce performance and aren't useful.
This commit is contained in:
Athozus 2023-05-23 17:49:17 +02:00 committed by GitHub
parent f8ace25104
commit 9679251249
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ui/events.lua
View File

@ -254,27 +254,17 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
elseif fields.selectall then elseif fields.selectall then
if formname == "mail:inbox" then if formname == "mail:inbox" then
if not mail.selected_idxs.inbox[name] then mail.selected_idxs.inbox[name] = {} -- reset for select, unselect and not existing
mail.selected_idxs.inbox[name] = {} mail.selected_idxs.multipleselection[name] = true -- enable as the button were pressed
end if #mail.selected_idxs.inbox[name] < #getInbox() then -- then populate it if selection isn't full
if #mail.selected_idxs.inbox[name] >= #getInbox() then -- if selection is full
mail.selected_idxs.inbox[name] = {}
else
mail.selected_idxs.inbox[name] = {} -- reset to avoid duplicates
mail.selected_idxs.multipleselection[name] = true
for _, msg in ipairs(getInbox()) do for _, msg in ipairs(getInbox()) do
table.insert(mail.selected_idxs.inbox[name], msg.id) table.insert(mail.selected_idxs.inbox[name], msg.id)
end end
end end
elseif formname == "mail:sent" then elseif formname == "mail:sent" then
if not mail.selected_idxs.sent[name] then mail.selected_idxs.sent[name] = {} -- reset for select, unselect and not existing
mail.selected_idxs.sent[name] = {} mail.selected_idxs.multipleselection[name] = true -- enable as the button were pressed
end if #mail.selected_idxs.sent[name] < #getOutbox() then -- then populate it if selection isn't full
if #mail.selected_idxs.sent[name] >= #getOutbox() then -- if selection is full
mail.selected_idxs.sent[name] = {}
else
mail.selected_idxs.sent[name] = {} -- reset to avoid duplicates
mail.selected_idxs.multipleselection[name] = true
for _, msg in ipairs(getOutbox()) do for _, msg in ipairs(getOutbox()) do
table.insert(mail.selected_idxs.sent[name], msg.id) table.insert(mail.selected_idxs.sent[name], msg.id)
end end