MTSR/mail
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicated variable

Browse Source
This commit is contained in:
Athozus 2023-05-20 20:29:00 +02:00
parent 02853fc3d0
commit f8ace25104
No known key found for this signature in database
GPG Key ID: B50895022E8484BF
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui/edit_maillists.lua
View File

@ -1,11 +1,9 @@
-- translation -- translation
local S = minetest.get_translator("mail") local S = minetest.get_translator("mail")
local old_lists_names = {}
local FORMNAME = "mail:editmaillist" local FORMNAME = "mail:editmaillist"
function mail.show_edit_maillist(playername, maillist_name, desc, players, illegal_name_hint) function mail.show_edit_maillist(playername, maillist_name, desc, players, illegal_name_hint)
old_lists_names[playername] = maillist_name
local formspec = [[ local formspec = [[
size[6,7] size[6,7]
button[4,6.25;2,0.5;back;]] .. S("Back") .. [[] button[4,6.25;2,0.5;back;]] .. S("Back") .. [[]
@ -42,16 +40,16 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
local maillists = mail.get_maillists(name) local maillists = mail.get_maillists(name)
if fields.save then if fields.save then
local old_maillist = maillists[mail.selected_idxs.maillists[name]] or {name = ""}
if mail.selected_idxs.maillists[name] then if mail.selected_idxs.maillists[name] then
local maillist = maillists[mail.selected_idxs.maillists[name]] or {name = ""} if old_maillist.name ~= fields.name or fields.name == "" then
if maillist.name ~= fields.name or fields.name == "" then
-- name changed! -- name changed!
if #fields.name == 0 then if #fields.name == 0 then
mail.show_edit_maillist(name, maillist.name, fields.desc, fields.players, "empty") mail.show_edit_maillist(name, old_maillist.name, fields.desc, fields.players, "empty")
return true return true
elseif mail.get_maillist_by_name(name, fields.name) then elseif mail.get_maillist_by_name(name, fields.name) then
mail.show_edit_maillist(name, maillist.name, fields.desc, fields.players, "collision") mail.show_edit_maillist(name, old_maillist.name, fields.desc, fields.players, "collision")
return true return true
else else
@ -60,7 +58,7 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
name = fields.name, name = fields.name,
desc = fields.desc, desc = fields.desc,
players = mail.parse_player_list(fields.players) players = mail.parse_player_list(fields.players)
}, old_lists_names[name]) }, old_maillist.name)
maillists[mail.selected_idxs.maillists[name]] = nil maillists[mail.selected_idxs.maillists[name]] = nil
end end
else else
@ -69,7 +67,7 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
name = fields.name, name = fields.name,
desc = fields.desc, desc = fields.desc,
players = mail.parse_player_list(fields.players) players = mail.parse_player_list(fields.players)
}, old_lists_names[name]) }, old_maillist.name)
end end
else else
mail.update_maillist(name, { mail.update_maillist(name, {
@ -77,7 +75,7 @@ minetest.register_on_player_receive_fields(function(player, formname, fields)
name = fields.name, name = fields.name,
desc = fields.desc, desc = fields.desc,
players = mail.parse_player_list(fields.players) players = mail.parse_player_list(fields.players)
}, old_lists_names[name]) }, old_maillist.name)
end end
mail.show_maillists(name) mail.show_maillists(name)