MTSR/minetest_modding_book
4
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix some Americanisms

Browse Source
This commit is contained in:
rubenwardy 2018-10-20 02:33:33 +01:00
parent 3819933de0
commit 5cad89cacc
No known key found for this signature in database
GPG Key ID: A1E29D52FF81513C
4 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
_en/items/node_drawtypes.md
View File

@ -173,7 +173,7 @@ minetest.register_node("default:water_source", {
-- ^ how far -- ^ how far
post_effect_color = {a=64, r=100, g=100, b=200}, post_effect_color = {a=64, r=100, g=100, b=200},
-- ^ color of screen when the player is submerged -- ^ colour of screen when the player is submerged
}) })
``` ```

2
_en/map/storage.md
View File

@ -99,7 +99,7 @@ This is useful in order to show the owner of the node or the status.
`description` is used in ItemStack Metadata to override the description when `description` is used in ItemStack Metadata to override the description when
hovering over the stack in an inventory. hovering over the stack in an inventory.
You can use colors by encoding them with `minetest.colorize()`. You can use colours by encoding them with `minetest.colorize()`.
`owner` is a common key used to store the username of the player that owns the `owner` is a common key used to store the username of the player that owns the
item or node. item or node.

2
_en/players/formspecs.md
View File

@ -87,7 +87,7 @@ At the time of writing, formspec information begins on line 1765.
## Displaying Formspecs ## Displaying Formspecs
Here is a generalized way to show a formspec: Here is a generalised way to show a formspec:
minetest.show_formspec(playername, formname, formspec) minetest.show_formspec(playername, formname, formspec)

8
_en/quality/security.md
View File

@ -41,12 +41,6 @@ Here's some real code found in a mod:
```lua ```lua
minetest.register_on_player_receive_fields(function(player, minetest.register_on_player_receive_fields(function(player,
formname, fields) formname, fields)
-- Todo: fix security issue here
local name = player:get_player_name()
if formname ~= "mymod:fs" then
return
end
for key, field in pairs(fields) do for key, field in pairs(fields) do
local x,y,z = string.match(key, local x,y,z = string.match(key,
"goto_([%d-]+)_([%d-]+)_([%d-]+)") "goto_([%d-]+)_([%d-]+)_([%d-]+)")
@ -59,7 +53,7 @@ minetest.register_on_player_receive_fields(function(player,
end end
``` ```
Can you spot the issue? A malicious user could submit a formspec containing Can you spot the problem? A malicious user could submit a formspec containing
their own position values, allowing them to teleport to anywhere they wish to. their own position values, allowing them to teleport to anywhere they wish to.
This could even be automated using client modifications to essentially replicate This could even be automated using client modifications to essentially replicate
the `/teleport` command with no need for a privilege. the `/teleport` command with no need for a privilege.