MTSR/xdecor-libre
4
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Improve performance of placing very long ropes

Browse Source
This commit is contained in:
Wuzzy 2024-03-08 13:49:23 +01:00
parent d88cfbf9d8
commit 992616a3f0
1 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/rope.lua
View File

@ -1,10 +1,12 @@
local rope = {} local rope = {}
local S = minetest.get_translator("xdecor") local S = minetest.get_translator("xdecor")
local MAX_ROPES = 99
local ropesounds = default.node_sound_leaves_defaults() local ropesounds = default.node_sound_leaves_defaults()
-- Code by Mirko K. (modified by Temperest, Wulfsdad, kilbith and Wuzzy) (License: GPL). -- Code by Mirko K. (modified by Temperest, Wulfsdad, kilbith and Wuzzy) (License: GPL).
function rope.place(itemstack, placer, pointed_thing) function rope.place(itemstack, placer, pointed_thing)
local creative = minetest.is_creative_enabled(placer:get_player_name())
if pointed_thing.type == "node" then if pointed_thing.type == "node" then
-- Use pointed node's on_rightclick function first, if present -- Use pointed node's on_rightclick function first, if present
if placer and not placer:get_player_control().sneak then if placer and not placer:get_player_control().sneak then
@ -23,24 +25,33 @@ function rope.place(itemstack, placer, pointed_thing)
local oldnode = minetest.get_node(pos) local oldnode = minetest.get_node(pos)
local stackname = itemstack:get_name() local stackname = itemstack:get_name()
-- Limit max. rope length to max. stack size -- Limit rope length to max. stack size or MAX_ROPES (whatever is smaller).
-- Prevents the rope to extend infinitely in Creative Mode -- Prevents the rope to extend infinitely in Creative Mode.
local max_ropes = itemstack:get_stack_max() local max_ropes = math.min(itemstack:get_stack_max(), MAX_ROPES)
-- Start placing ropes and extend it downwards until we run out of ropes
-- or hit the maximum
local start_pos = table.copy(pos) local start_pos = table.copy(pos)
local ropes_placed = 0 local ropes_to_place = 0
while oldnode.name == "air" and not itemstack:is_empty() and ropes_placed < max_ropes do local new_rope_nodes = {}
local newnode = {name = stackname, param1 = 0} while oldnode.name == "air" and (creative or (ropes_to_place < itemstack:get_size())) and ropes_to_place < max_ropes do
minetest.set_node(pos, newnode) table.insert(new_rope_nodes, table.copy(pos))
if not minetest.is_creative_enabled(placer:get_player_name()) then
itemstack:take_item()
end
pos.y = pos.y - 1 pos.y = pos.y - 1
oldnode = minetest.get_node(pos) oldnode = minetest.get_node(pos)
ropes_placed = ropes_placed + 1 ropes_to_place = ropes_to_place + 1
end end
local newnode = {name = stackname}
if ropes_to_place == 1 then
minetest.set_node(new_rope_nodes[1], newnode)
else
minetest.bulk_set_node(new_rope_nodes, newnode)
end
if not creative then
itemstack:take_item(ropes_to_place)
end
-- Play placement sound manually -- Play placement sound manually
if ropes_placed > 0 then if ropes_to_place > 0 then
minetest.sound_play(ropesounds.place, {pos=start_pos}, true) minetest.sound_play(ropesounds.place, {pos=start_pos}, true)
end end
end end